chore(volta): update adr 0014 to officially adopt volta#3179
Merged
rwaskiewicz merged 2 commits intomainfrom Jan 4, 2022
Merged
chore(volta): update adr 0014 to officially adopt volta#3179rwaskiewicz merged 2 commits intomainfrom
rwaskiewicz merged 2 commits intomainfrom
Conversation
designate the volta adr as accepted and that volta is an official part of our development toolchain. this comes after a month of using volta with no major issues in the codebase.
ltm
approved these changes
Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run test.karma.prod) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Volta is consider experimental/on a trial run in the docs. It's been a month with no major issues, let's make this GitHub official
GitHub Issue Number: N/A
What is the new behavior?
designate the volta adr as accepted and that volta is an official part
of our development toolchain. this comes after a month of using volta
with no major issues in the codebase.
Does this introduce a breaking change?
Testing
N/A