Skip to content

chore(volta): update adr 0014 to officially adopt volta#3179

Merged
rwaskiewicz merged 2 commits intomainfrom
update-volta-adr
Jan 4, 2022
Merged

chore(volta): update adr 0014 to officially adopt volta#3179
rwaskiewicz merged 2 commits intomainfrom
update-volta-adr

Conversation

@rwaskiewicz
Copy link
Copy Markdown
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Unit tests (npm test) were run locally and passed
  • E2E Tests (npm run test.karma.prod) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Volta is consider experimental/on a trial run in the docs. It's been a month with no major issues, let's make this GitHub official

GitHub Issue Number: N/A

What is the new behavior?

designate the volta adr as accepted and that volta is an official part
of our development toolchain. this comes after a month of using volta
with no major issues in the codebase.

Does this introduce a breaking change?

  • Yes
  • No

Testing

N/A

designate the volta adr as accepted and that volta is an official part
of our development toolchain. this comes after a month of using volta
with no major issues in the codebase.
@rwaskiewicz rwaskiewicz requested a review from a team December 9, 2021 15:45
@rwaskiewicz rwaskiewicz merged commit e1e9bb0 into main Jan 4, 2022
@rwaskiewicz rwaskiewicz deleted the update-volta-adr branch January 4, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants