chore(tests): audit karma test suite packages#3178
Merged
rwaskiewicz merged 8 commits intomainfrom Jan 4, 2022
Merged
Conversation
results of running `npm audit fix --only=dev` within the `test/karma` directory. a good deal of the security vulnerabilities that GitHub warns us about are in this directory, and many can be fixed (assuming packages follow semver) with a quick audit+fix
upgrade webpack-cli to v4 from v3 to resolve security issuse found in v3. there appears to be only one breaking change in v4 insofar as i can tell (`--plugin` is removed) and it does not affect us since we use this cli in such a limited capacity
remove unused plugin
remove unused plugin
remove unused plugin
a8f7135 to
de1d050
Compare
install karma-jasmine v4. the only breaking change is v4 drops node 8 support and adds node 14 support, which does not apply to this section of the codebase
ltm
approved these changes
Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run test.karma.prod) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
There are several vulnerabilities being reported via GitHub about packages in our Karma tests.
GitHub Issue Number: N/A
What is the new behavior?
npm audit fix --only=devwithin thetest/karmadirectory. a good deal of the security vulnerabilities that GitHub warns
us about are in this directory, and many can be fixed (assuming packages
follow semver) with a quick audit+fix
v3. there appears to be only one breaking change in v4 insofar as i can
tell (
--pluginis removed) and it does not affect us since we use thiscli in such a limited capacity
support and adds node 14 support, which does not apply to this section
of the codebase
Does this introduce a breaking change?
Testing
between each commit,
npm ci && npm run karma.prodwas run from thetests/karmadirectoryOther information
I did not attempt to upgrade Karma in the scope of this PR, which is reporting a few vulnerabilities ATM