Skip to content

chore(sourcemaps): create linker string util#3077

Merged
rwaskiewicz merged 1 commit intorwaskiewicz-rebase-again-sourcemapsfrom
rwaskiewicz/sourcemaps/coalesce-link-strings
Sep 23, 2021
Merged

chore(sourcemaps): create linker string util#3077
rwaskiewicz merged 1 commit intorwaskiewicz-rebase-again-sourcemapsfrom
rwaskiewicz/sourcemaps/coalesce-link-strings

Conversation

@rwaskiewicz
Copy link
Copy Markdown
Member

@rwaskiewicz rwaskiewicz commented Sep 22, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Unit tests (npm test) were run locally and passed
  • E2E Tests (npm run test.karma.prod) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

While going through the #3005, I realized that we use the source map linking string in multiple places. This isn't ideal, because I think at some point we're going to need to specially encode the URL, and I'd prefer not to update it in several locations

GitHub Issue Number: N/A

What is the new behavior?

  • Extracts the generation of the URL linker into two helper methods

Does this introduce a breaking change?

  • Yes
  • No

Testing

  • Added unit tests
  • Smoke tested with a sample Stencil app, with a global script defined/created

Other information

Copy link
Copy Markdown
Contributor

@splitinfinities splitinfinities left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight forward!

@rwaskiewicz rwaskiewicz merged commit 39f7356 into rwaskiewicz-rebase-again-sourcemaps Sep 23, 2021
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz/sourcemaps/coalesce-link-strings branch September 23, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants