chore(sourcemaps): create linker string util#3077
Merged
rwaskiewicz merged 1 commit intorwaskiewicz-rebase-again-sourcemapsfrom Sep 23, 2021
Merged
Conversation
splitinfinities
approved these changes
Sep 23, 2021
Contributor
splitinfinities
left a comment
There was a problem hiding this comment.
Straight forward!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run test.karma.prod) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
While going through the #3005, I realized that we use the source map linking string in multiple places. This isn't ideal, because I think at some point we're going to need to specially encode the URL, and I'd prefer not to update it in several locations
GitHub Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Testing
Other information