fix(mock-doc): handle undefined delay in setTimeout/setInterval#6539
Merged
johnjenkins merged 1 commit intostenciljs:mainfrom Jan 9, 2026
Merged
fix(mock-doc): handle undefined delay in setTimeout/setInterval#6539johnjenkins merged 1 commit intostenciljs:mainfrom
johnjenkins merged 1 commit intostenciljs:mainfrom
Conversation
johnjenkins
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the
TimeoutNaNWarningthat may be emitted by Node.js during SSR hydration whensetTimeoutorsetIntervalis called without a delay argument.Problem
When components call
setTimeout(callback)without specifying a delay during SSR, theMockWindowimplementation could potentially passNaNto the nativesetTimeout:Node.js may then coerce
NaNto 1ms and emit a warning:Proposed Solution
Use nullish coalescing to default
undefinedto0before theMath.mincall:This should align with browser behavior where
setTimeout(fn)andsetTimeout(fn, undefined)both default to 0ms delay.