Skip to content

bug: globalStyle failing HMR on Windows #4961

@4leite

Description

@4leite

Prerequisites

Stencil Version

4.5.0

Current Behavior

Stencil in watch mode does not rebuild when config.globalStyle is updated on windows.

Expected Behavior

Changing config.globalStyle should trigger a rebuild.

System Info

Latest Windows (this is relevant because the bug will not be present on linux).

Steps to Reproduce

npm run start
make a change to /src/global.css eg change "--color-primary: red;" to blue.
change is not reflected in browser.

Code Reproduction URL

https://github.com/Datacom-Digital/stencil-bug

Additional Information

This is because buildCtx.filesChanged is normalised but config.globalStyle is not so the string compare fails. This is probably effecting imports as well however i don't use them in my project so haven't checked.

See #4898 for the patch that fixed the issue for me.

Metadata

Metadata

Assignees

Labels

Bug: ValidatedThis PR or Issue is verified to be a bug within Stencil

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions