-
-
Notifications
You must be signed in to change notification settings - Fork 832
Closed
Labels
Bug: ValidatedThis PR or Issue is verified to be a bug within StencilThis PR or Issue is verified to be a bug within Stencil
Description
Prerequisites
- I have read the Contributing Guidelines.
- I agree to follow the Code of Conduct.
- I have searched for existing issues that already report this problem, without success.
Stencil Version
v2.17.3 (Seen in at least 2.16.1 as well)
Current Behavior
Type errors are not erroring on initial builds (no build outputs), but will on subsequent builds.
This is an issue especially in CI, as we re-create the entire environment. The CI workflow will not error if a type error is committed.
Expected Behavior
The type error should cause the build to error
Steps to Reproduce
- Clone the stencil starter
- Delete
components.d.ts - Change the exports in
index.tsto be named orexport * from ./componentsor deleteindex.ts - Make a type error somewhere
npm run build-> build completes with no errors
OR
- In a project that does not commit the
components.d.ts, simply delete it, and note that the type error will not be reported.
(I have provided a repo that matches our setup)
Code Reproduction URL
https://github.com/ethanbdev/stencil-typings-error-repro
Additional Information
It seems extremely breaking that we cannot rely on the types generated in an initial build.
One additional thing I noticed, in the stencil starter if the components.d.ts gets deleted, the build does not even work with a different error about the ./components file is not found
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Bug: ValidatedThis PR or Issue is verified to be a bug within StencilThis PR or Issue is verified to be a bug within Stencil
