Skip to content

fix(compiler): Prevent extTransformsPlugin from outputting collection dependency css#3306

Merged
christian-bromann merged 2 commits intostenciljs:mainfrom
George-Payne:prevent-ext-transforms-plugin-from-outputing-collection-dependency-css
Jun 11, 2025
Merged

fix(compiler): Prevent extTransformsPlugin from outputting collection dependency css#3306
christian-bromann merged 2 commits intostenciljs:mainfrom
George-Payne:prevent-ext-transforms-plugin-from-outputing-collection-dependency-css

Conversation

@George-Payne
Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Unit tests (npm test) were run locally and passed
  • E2E Tests (npm run test.karma.prod) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #3305

What is the new behavior?

extTransformsPlugin will no longer output collection dependency css when building collection files.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Linked build of stencil to reproduction lib and rebuilt lib.

Other information

@George-Payne George-Payne requested a review from a team March 28, 2022 17:07
@George-Payne George-Payne force-pushed the prevent-ext-transforms-plugin-from-outputing-collection-dependency-css branch from 186d265 to efc58a7 Compare March 29, 2022 08:55
@George-Payne George-Payne changed the title Prevent extTransformsPlugin from outputting collection dependency css fix(compiler): Prevent extTransformsPlugin from outputting collection dependency css Mar 29, 2022
@mikaelkaron
Copy link
Copy Markdown

patch works here.

@christian-bromann christian-bromann requested a review from a team as a code owner June 9, 2025 22:23
Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit 28e2a06 into stenciljs:main Jun 11, 2025
143 of 144 checks passed
@George-Payne George-Payne deleted the prevent-ext-transforms-plugin-from-outputing-collection-dependency-css branch June 11, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants