Winter Holiday Triage and PR Review
2021.01.04 Update
Welcome back everyone! The repo's bot will no longer be telling folks that the Stencil team is on holiday. I'm going to leave this issue pinned for a bit while we work through triaging the issues that came in through during the break. Thank you for you patience ahead of time while we dig in!
With the winter holidays quickly approaching, much of the Stencil Team will soon be taking time off. During this time, issue triaging and PR review will be delayed until the team begins to return. After this period, we will work to ensure that all new issues are properly triaged and that new PRs are reviewed.
Filing an issue? Here are some things you can do to ensure that it is triaged correctly:
- When filing an issue, fill out the template completely. This includes a description of the bug, steps to reproduce, and the version of Stencil you're using
- Be sure to provide a code reproduction. The best way to do this is to reproduce the issue you are experiencing in a Stencil component starter library and include a link to the GitHub repo in your issue (
npm init stencil -> choose 'component'). Code snippets typically are not enough to reproduce the issue, so a GitHub repo is best.
- Be sure to follow all the steps in our Creating an Issue Guide.
Opening a PR? Here are some things you can do to ensure that it is easy to review:
- Verify that all tests on the PR are passing. If you see a red "X" on a test, click on the "Details" link to find out why a particular test is failing.
- If CI won't run because running the workflow hasn't been approved, you can run the unit tests and e2e tests locally (
npm t and npm run test.karma.prod, respectively)
- Include a link to the original issue in your PR description. If there is no issue yet, please create one! PRs without associated issues are not likely to get merged.
- Be sure to follow all the steps in our Creating a Pull Request Guide.
If you are in need of immediate assistance, we recommend creating a new post on the Ionic Forums.
We have a lot of exciting things planned for Stencil in 2022, primarily focusing on open source & addressing the needs of the community. Until then, have a happy and healthy holiday, and we will see you in the new year!
The Stencil Team
Winter Holiday Triage and PR Review
2021.01.04 Update
Welcome back everyone! The repo's bot will no longer be telling folks that the Stencil team is on holiday. I'm going to leave this issue pinned for a bit while we work through triaging the issues that came in through during the break. Thank you for you patience ahead of time while we dig in!
With the winter holidays quickly approaching, much of the Stencil Team will soon be taking time off. During this time, issue triaging and PR review will be delayed until the team begins to return. After this period, we will work to ensure that all new issues are properly triaged and that new PRs are reviewed.
Filing an issue? Here are some things you can do to ensure that it is triaged correctly:
npm init stencil-> choose 'component'). Code snippets typically are not enough to reproduce the issue, so a GitHub repo is best.Opening a PR? Here are some things you can do to ensure that it is easy to review:
npm tandnpm run test.karma.prod, respectively)If you are in need of immediate assistance, we recommend creating a new post on the Ionic Forums.
We have a lot of exciting things planned for Stencil in 2022, primarily focusing on open source & addressing the needs of the community. Until then, have a happy and healthy holiday, and we will see you in the new year!
The Stencil Team