Skip to content

Make events a list of lists so we can associate events with their operation#52

Closed
paulbellamy wants to merge 2 commits intostellar:mainfrom
paulbellamy:operation-indexed-events
Closed

Make events a list of lists so we can associate events with their operation#52
paulbellamy wants to merge 2 commits intostellar:mainfrom
paulbellamy:operation-indexed-events

Conversation

@paulbellamy
Copy link
Contributor

@paulbellamy paulbellamy commented Nov 17, 2022

With the old schema, it is impossible to tell which operations emitted which events. This is not an issue now, as there is only one operation in soroban txns, but if we support multiple in future, it would be an issue. To prevent that we can change the events field to be a list of lists (one list per operation).

Two questions:

  • Anywhere else we need to update this? (aside from propagating it through core/soroban-cli/go/js/etc...)
  • Do we need the OperationEvents struct? Is there a simpler way to do an inline nested list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants