Make events a list of lists so we can associate events with their operation#52
Closed
paulbellamy wants to merge 2 commits intostellar:mainfrom
Closed
Make events a list of lists so we can associate events with their operation#52paulbellamy wants to merge 2 commits intostellar:mainfrom
paulbellamy wants to merge 2 commits intostellar:mainfrom
Conversation
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the old schema, it is impossible to tell which operations emitted which events. This is not an issue now, as there is only one operation in soroban txns, but if we support multiple in future, it would be an issue. To prevent that we can change the events field to be a list of lists (one list per operation).
Two questions: