Conversation
sreuland
reviewed
Nov 26, 2025
Shaptic
reviewed
Dec 2, 2025
…sion, or dev if no match
Co-authored-by: George <Shaptic@users.noreply.github.com>
…ithub.com/stellar/stellar-rpc into support-version-parameter-on-command-line
Shaptic
approved these changes
Dec 3, 2025
Contributor
Shaptic
left a comment
There was a problem hiding this comment.
LGTM! Just add a bit of explanation to the parsing
…ithub.com/stellar/stellar-rpc into support-version-parameter-on-command-line
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR expands the
./stellar-rpc versioncommand by adding information about the rs-soroban-env versions (both prev, which is supported, and current). This information is sourced fromcargo.toml. Additionally, due to a bug in how a patch for Darwin/MacOS was applied, the version command would never work on MacOS (all Go linker flags are overwritten on MacOS). This PR fixes that.Why
This enables rapid access to versioning information for RPC components. Re: #42
Known limitations
N/A.