Skip to content

Added rs-soroban-env version info to version command, patch command for MacOS#550

Merged
cjonas9 merged 12 commits intomainfrom
support-version-parameter-on-command-line
Dec 3, 2025
Merged

Added rs-soroban-env version info to version command, patch command for MacOS#550
cjonas9 merged 12 commits intomainfrom
support-version-parameter-on-command-line

Conversation

@cjonas9
Copy link
Contributor

@cjonas9 cjonas9 commented Nov 26, 2025

What

This PR expands the ./stellar-rpc version command by adding information about the rs-soroban-env versions (both prev, which is supported, and current). This information is sourced from cargo.toml. Additionally, due to a bug in how a patch for Darwin/MacOS was applied, the version command would never work on MacOS (all Go linker flags are overwritten on MacOS). This PR fixes that.

Why

This enables rapid access to versioning information for RPC components. Re: #42

Known limitations

N/A.

@cjonas9 cjonas9 linked an issue Nov 26, 2025 that may be closed by this pull request
@cjonas9 cjonas9 marked this pull request as ready for review November 26, 2025 19:57
@cjonas9 cjonas9 requested a review from a team December 3, 2025 22:52
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just add a bit of explanation to the parsing

@cjonas9 cjonas9 changed the title Fix broken version command, added rs-soroban-env version info Added rs-soroban-env version info to version command, patch command for MacOS Dec 3, 2025
@cjonas9 cjonas9 merged commit 312ad9b into main Dec 3, 2025
62 of 71 checks passed
@cjonas9 cjonas9 deleted the support-version-parameter-on-command-line branch December 3, 2025 23:45
@cjonas9 cjonas9 mentioned this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support version parameter on command line

4 participants