Optimize getLedgers queries by only decoding the header#505
Merged
Conversation
sreuland
reviewed
Sep 5, 2025
sreuland
reviewed
Sep 5, 2025
sreuland
reviewed
Sep 5, 2025
sreuland
reviewed
Sep 5, 2025
sreuland
approved these changes
Sep 5, 2025
Contributor
sreuland
left a comment
There was a problem hiding this comment.
novel solution, nice work!
tamirms
reviewed
Sep 8, 2025
…c into getLedgers_depthCheck
tamirms
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Instead of decoding the raw binary data directly into an
xdr.LedgerCloseMeta, this modifies the code to only decode thexdr.LedgerHeaderHistoryEntryout of the data which comes first in the layout. The rest of the meta is passed around directly as a[]byteuntil the final step, either converting it to base64 directly or to JSON.Rudimentary benchmarks show a ~40% improvement over the baseline:
Why
We have observed performance issues with
getLedgersdue to their density and would like to improve them.Known limitations
This needs to be evaluated against real load to see the improvement.