refactor: replace []byte(fmt.Sprintf) with fmt.Appendf#496
Merged
Shaptic merged 4 commits intostellar:mainfrom Sep 11, 2025
Merged
refactor: replace []byte(fmt.Sprintf) with fmt.Appendf#496Shaptic merged 4 commits intostellar:mainfrom
Shaptic merged 4 commits intostellar:mainfrom
Conversation
Signed-off-by: deepdring <deepdrink@icloud.com>
Contributor
Author
|
friendly ping |
Contributor
Author
|
Thanks for your review! Look like the CI error has not related with this pr. > [internal] load git source https://github.com/stellar/go.git#protocol-23:
0.009 Initialized empty Git repository in /var/lib/docker/overlay2/9uyatn086bk6p9e4uibnao281/diff/
------
ERROR: failed to build: failed to solve: failed to read dockerfile: failed to load cache key: repository does not contain ref protocol-23, output: ""
make: *** [Makefile:84: build-friendbot] Error 1
Error: Process completed with exit code 2. |
Shaptic
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Inspired by #476 and replace all.
Optimize code using a more modern writing style. Official support by Go Team. https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize.
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]