Fix memory leak when passing XDR data to Rust#472
Merged
2opremio merged 2 commits intostellar:mainfrom Jul 14, 2025
Merged
Conversation
tamirms
reviewed
Jul 14, 2025
tamirms
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deallocate XDR data after passing it down to Rust for JSON conversion.
Also, make sure that XDR converted to C representation is deallocated in the case of any errors.
Why
Otherwise the XDR data is leaked. It may be the culprit of #448 (or part of it at least).
This effectively was causing leaks amounting to the size of any XDR data converted to JSON.
Known limitations
N/A