Skip to content

v23.0.0 Release Candidate 2#471

Merged
Shaptic merged 14 commits intoprotocol-23from
release/v23.0.0-rc.2
Jul 16, 2025
Merged

v23.0.0 Release Candidate 2#471
Shaptic merged 14 commits intoprotocol-23from
release/v23.0.0-rc.2

Conversation

@Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Jul 10, 2025

Holding release branch for rc.2 changes.

@overcat
Copy link
Contributor

overcat commented Jul 14, 2025

Hi @Shaptic, I would like to ask if we will update stellar/go to the latest version when we release RPC v23?

@Shaptic
Copy link
Contributor Author

Shaptic commented Jul 14, 2025

@overcat there shouldn't be any meaningful changes but it doesn't hurt! Done in 24076f8.

@Shaptic Shaptic force-pushed the release/v23.0.0-rc.2 branch from 5304975 to 1b56df3 Compare July 14, 2025 18:31
@Shaptic Shaptic force-pushed the release/v23.0.0-rc.2 branch from 04b7868 to 04c0f62 Compare July 14, 2025 20:31
@Shaptic Shaptic requested a review from a team July 14, 2025 21:12
@overcat
Copy link
Contributor

overcat commented Jul 14, 2025

@overcat there shouldn't be any meaningful changes but it doesn't hurt! Done in 24076f8.

@Shaptic, I initially didn't notice that there was a p23 branch in stellar/go 🤦, so this commit was added to the master branch. It may require some handling to include it here. I think we should include it so that RPC can use S3 as a data source.

@Shaptic
Copy link
Contributor Author

Shaptic commented Jul 14, 2025

@overcat ah good call! I opened https://github.com/stellar/go/pull/5751.

@overcat
Copy link
Contributor

overcat commented Jul 14, 2025

@overcat ah good call! I opened stellar/go#5751.

👍 Nice, thank you @Shaptic

@Shaptic
Copy link
Contributor Author

Shaptic commented Jul 15, 2025

@overcat we're in the process of making changes to the S3 backend so that it can access read-only buckets plus add testing for robustness, etc. This improvement would only make it into the next release candidate(s). However, I can make RPC's rc.2 point to the above PR's branch for this RC if the feature is important enough to get out 🤙

@overcat
Copy link
Contributor

overcat commented Jul 15, 2025

@overcat we're in the process of making changes to the S3 backend so that it can access read-only buckets plus add testing for robustness, etc. This improvement would only make it into the next release candidate(s). However, I can make RPC's rc.2 point to the above PR's branch for this RC if the feature is important enough to get out 🤙

This is not urgent; I think we can postpone it.

@Shaptic Shaptic merged commit fb10387 into protocol-23 Jul 16, 2025
21 of 28 checks passed
@Shaptic Shaptic deleted the release/v23.0.0-rc.2 branch July 16, 2025 22:52
@Shaptic Shaptic restored the release/v23.0.0-rc.2 branch July 16, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants