Skip to content

Enforce autorestore for simulations in protocols > 22#463

Merged
2opremio merged 11 commits intostellar:protocol-23from
2opremio:enable-sim-autorestore
Jun 26, 2025
Merged

Enforce autorestore for simulations in protocols > 22#463
2opremio merged 11 commits intostellar:protocol-23from
2opremio:enable-sim-autorestore

Conversation

@2opremio
Copy link
Contributor

@2opremio 2opremio commented Jun 25, 2025

What

Enforce autorestore for simulations in protocols > 22, by including the required archivedEntries vector in the SorobanResourcesExtV0 of the SorobanTransactionData returned by the simulateTransaction method.

Why

Autorestore wasn't working in the simulation of protocol 23

Known limitations

The restore preamble won't be generated in the corner cases in which autorestore isn't enough. (See #464 )

@2opremio 2opremio force-pushed the enable-sim-autorestore branch from e857597 to 88dcc1d Compare June 25, 2025 17:56
@2opremio 2opremio marked this pull request as draft June 25, 2025 17:56
@2opremio 2opremio marked this pull request as ready for review June 25, 2025 23:12
@2opremio 2opremio requested a review from Shaptic June 25, 2025 23:12
Copy link
Contributor

@dmkozh dmkozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust part LGTM

@2opremio 2opremio merged commit a1ec02a into stellar:protocol-23 Jun 26, 2025
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants