Enforce autorestore for simulations in protocols > 22#463
Merged
2opremio merged 11 commits intostellar:protocol-23from Jun 26, 2025
Merged
Enforce autorestore for simulations in protocols > 22#4632opremio merged 11 commits intostellar:protocol-23from
2opremio merged 11 commits intostellar:protocol-23from
Conversation
e857597 to
88dcc1d
Compare
Shaptic
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enforce autorestore for simulations in protocols > 22, by including the required
archivedEntriesvector in theSorobanResourcesExtV0of theSorobanTransactionDatareturned by thesimulateTransactionmethod.Why
Autorestore wasn't working in the simulation of protocol 23
Known limitations
The restore preamble won't be generated in the corner cases in which autorestore isn't enough. (See #464 )