Expand events in getTransaction response#455
Merged
2opremio merged 11 commits intostellar:protocol-23from Jun 9, 2025
Merged
Conversation
e6f5064 to
ce73695
Compare
…ent types of events in addition to the existing DiagnosticEvents
ce73695 to
fc4bdd2
Compare
2opremio
reviewed
Jun 4, 2025
2opremio
reviewed
Jun 4, 2025
This was referenced Jun 8, 2025
Contributor
|
I've created stellar/stellar-docs#1568 to document the new fields. I will work on a draft PR. |
2opremio
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Introduce an
eventsobject in thegetTransactionandgetTransactionsAPI response. The event object will include diagnosticEvents, contractEvents, and transactionEvents.Diagnostic events will only contain diagnostic and system events, excluding contract events.
Contract events will be structured as a slice of slices ([][]), where each inner slice will contain contract events for a specific operation. It would be unnecessarily complicated to flatten this into a single [] for soroban transactions, so keeping it as [][] for all transactions.
Transaction events will simply contain transaction level events (fees, refunds, etc.)
All event types (diagnostic, contract and transaction events) will support both json and xdr formats. If any event type is empty, it will be omitted from the response.
This change is additive. The existing
diagnosticEventsfield will remain as-is for P23, but it will be marked as deprecated and will be removed in P24.Sample
getTransactionResponse:Why
#450
Known limitations