Fix "**" wildcard validation for correct json parsing#449
Merged
urvisavla merged 3 commits intostellar:protocol-23from May 28, 2025
Merged
Fix "**" wildcard validation for correct json parsing#449urvisavla merged 3 commits intostellar:protocol-23from
urvisavla merged 3 commits intostellar:protocol-23from
Conversation
e4aa599 to
4597e96
Compare
Contributor
|
Wouldn't it make more sense to target the main branch? (since it's not protocol-23 specific AFAICT) (we will merge the protocol-23 branch into main before releasing anyways) |
Contributor
Author
The original issue #358 was tagged protocol-23 so I added the feature in protocol-23 branch. This feature doesn't exist in main yet. |
sreuland
reviewed
May 28, 2025
sreuland
approved these changes
May 28, 2025
Contributor
sreuland
left a comment
There was a problem hiding this comment.
lgtm, thorough test coverage!
Shaptic
approved these changes
May 28, 2025
Contributor
Shaptic
left a comment
There was a problem hiding this comment.
Nice test coverage for the new feature 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In #419, we added the
"**"wildcard filter for flexible topic matching, restricted to the last segment. This restriction was enforced in SegmentFilter which broke json parsing during request unmarshaling. This fix moves the"**"validation to TopicFilter to ensure correct parsing as well as placement checks.changelog entry has also been added.
Known limitations
N/A