Add support for non-root authorization in simulation#432
Merged
Shaptic merged 18 commits intoprotocol-23from May 22, 2025
Merged
Add support for non-root authorization in simulation#432Shaptic merged 18 commits intoprotocol-23from
Shaptic merged 18 commits intoprotocol-23from
Conversation
Closed
6af7d74 to
07dcd13
Compare
14f9d9a to
c49211f
Compare
a662cfa to
f54fbcd
Compare
555d997 to
934fd51
Compare
2opremio
reviewed
May 21, 2025
2opremio
reviewed
May 21, 2025
2opremio
reviewed
May 21, 2025
2opremio
reviewed
May 21, 2025
2opremio
reviewed
May 21, 2025
dmkozh
reviewed
May 21, 2025
Add test ensuring default non-root behavior works
2opremio
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
soroban-env-host-prevto P22 and-currto P23GoLedgerStoragetrait implementations for Protocol 22 (which usesSnapshotSourceWithArchive) and Protocol 23 (which just usesSnapshotSource)simulateTransaction:which explicitly allows users to opt-in to non-root authorization in recording mode.
The behavior rules are:
enforceif auth entries are present,recordotherwise (the behavior today)enforce: always enforcement mode, even with an empty listrecord: always recording mode, failing if any auth existsrecord_allow_nonroot: likerecordbut allowing non-root authorizationWhy
Handle the breaking changes across the Protocol 22 and 23 simulation libraries cleanly.
Add non-root simulation support for both protocols per #344.
Known limitations
Integration testing isn't possible without an accompanying Core build.