Ignore state change entries which don't incur an actual diff#396
Merged
Ignore state change entries which don't incur an actual diff#396
Conversation
Member
I think the key here is that while this change will stop rpc from erroring, rpc's response won't be usable by clients to create the footprint required to submit the tx because the client won't know which ledger entry the (null,null) refers to, in the same way that rpc doesn't know. Is that correct? |
Contributor
Author
|
@leighmcculloch thankfully, no. This only affects the |
tamirms
approved these changes
Apr 8, 2025
2opremio
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Even though the key was touched (but left unchanged), it won't appear in the list of state changes. This is semantically fine, since no state changed.
Why
Closes #390 until stellar/rs-soroban-env#1448 is done. Simulation should still be able to succeed in these cases.
Known limitations
A bit hacky, but it's a temporary fix until the "proper" one is done in P23, where we'll include the key itself and allow
null/nullfor before/after.