Skip to content

Remove all TransactionResultSetV2 related changes and puts the hash of the events and return values in InvokeHostFunctionResult#3714

Merged
latobarita merged 10 commits intostellar:masterfrom
sisuresh:undo-trs
May 15, 2023
Merged

Remove all TransactionResultSetV2 related changes and puts the hash of the events and return values in InvokeHostFunctionResult#3714
latobarita merged 10 commits intostellar:masterfrom
sisuresh:undo-trs

Conversation

@sisuresh
Copy link
Contributor

@sisuresh sisuresh commented Apr 21, 2023

Description

Resolves #3555

This change uses the xdr from this PR.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@sisuresh sisuresh changed the title WIP - Remove all TransactionResultSetV2 related changes and puts the hash of TxHashOfMetaHashesSet in the new LedgerHeaderExtensionV2 WIP - Remove all TransactionResultSetV2 related changes and puts the hash of the events and return values in InvokeHostFunctionResult May 8, 2023
@sisuresh sisuresh changed the title WIP - Remove all TransactionResultSetV2 related changes and puts the hash of the events and return values in InvokeHostFunctionResult Remove all TransactionResultSetV2 related changes and puts the hash of the events and return values in InvokeHostFunctionResult May 8, 2023
@sisuresh sisuresh marked this pull request as ready for review May 8, 2023 21:45
@graydon
Copy link
Contributor

graydon commented May 15, 2023

r+ 0aba7e6

@graydon
Copy link
Contributor

graydon commented May 15, 2023

(note: something's wrong with the dep tree here, but I thin it's a bug in cargo-lock, landing as-is for now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finalize soroban-era hashing, storage and emitting of TransactionResultSet vs. TransactionResultSetV2

3 participants