Updated handling of configuration ledger entries#3522
Closed
dmkozh wants to merge 7 commits intostellar:masterfrom
Closed
Updated handling of configuration ledger entries#3522dmkozh wants to merge 7 commits intostellar:masterfrom
dmkozh wants to merge 7 commits intostellar:masterfrom
Conversation
graydon
reviewed
Sep 2, 2022
.gitmodules
Outdated
| ignore = dirty | ||
| [submodule "src/protocol-next/xdr"] | ||
| path = src/protocol-next/xdr | ||
| url = https://github.com/stellar/stellar-xdr-next.git |
Contributor
There was a problem hiding this comment.
I suspect this needs to switch back to the stellar repo?
Contributor
Author
There was a problem hiding this comment.
Sure (hence the !removeme commit) - IIUC that's the only way to make the tests pass before the XDR changes are merged.
This is to support how the new XDR is generated.
While this can be supported from the ledger standpoint, I think that semantically these shouldn't be removed and hence it's better to introduce some harness to make sure we don't accidentally remove it.
- Add methods to generate unique entries, so that we don't need to exclude `CONFIG_SETTING` entry from the fuzzer due to them having key collisions - Add methods to generate entries of given type and entries with exclusions to be more explicit about including/excluding the entry types where relevant
…of `CONFIG_SETTING` entries.
c259687 to
d53312b
Compare
Contributor
|
I think this is now obsolete -- @dmkozh you can close it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These updates are based on my previous work on SPEEDEX configuration PR.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)