Skip to content

Append custom meta entries in one section #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elizabethengelman merged 1 commit into from
Sep 29, 2025
Merged

Append custom meta entries in one section #2229

elizabethengelman merged 1 commit into from
Sep 29, 2025

Conversation

@elizabethengelman
Copy link
Collaborator

@elizabethengelman elizabethengelman commented Sep 29, 2025 •
edited
Loading

What

Closes #1721

Before

> stellar contract build --manifest-path ./cmd/crates/soroban-test/tests/fixtures/test-wasms/test/Cargo.toml --meta one=two --meta three=four

> wasm-tools print target/wasm32v1-none/release/test.wasm
...
  (@producers
    (language "Rust" "")
    (processed-by "rustc" "1.89.0 (29483883e 2025-08-04)")
  )
  (@custom "target_features" (after data) "\01+\0fmutable-globals")
  (@custom "contractmetav0" (after data) "\00\00\00\00\00\00\00\03one\00\00\00\00\03two\00")
  (@custom "contractmetav0" (after data) "\00\00\00\00\00\00\00\05three\00\00\00\00\00\00\04four")
)

After

> cargo run contract build --manifest-path ./cmd/crates/soroban-test/tests/fixtures/test-wasms/test/Cargo.toml --meta one=two --meta three=four

> wasm-tools print target/wasm32v1-none/release/test.wasm

...
  (@producers
    (language "Rust" "")
    (processed-by "rustc" "1.89.0 (29483883e 2025-08-04)")
  )
  (@custom "target_features" (after data) "\01+\0fmutable-globals")
  (@custom "contractmetav0" (after data) "\00\00\00\00\00\00\00\03one\00\00\00\00\03two\00\00\00\00\00\00\00\00\05three\00\00\00\00\00\00\04four")
)

Why

Using this PR instead of #2095

Instead of re-writing the whole wasm structure, this PR just appends all of the custom metas to be added to just one new custom section.

Known limitations

n/a

@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Sep 29, 2025
@elizabethengelman elizabethengelman self-assigned this Sep 29, 2025
@elizabethengelman elizabethengelman force-pushed the fix/meta-duplicates-updated branch from 5efe3ce to edd408c Compare September 29, 2025 19:38
@elizabethengelman elizabethengelman mentioned this pull request Sep 29, 2025
Closed
@elizabethengelman elizabethengelman marked this pull request as ready for review September 29, 2025 21:01
@elizabethengelman elizabethengelman requested a review from a team as a code owner September 29, 2025 21:01
@elizabethengelman elizabethengelman merged commit 85c7d1d into main Sep 29, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from Backlog (Not Ready) to Done in DevX Sep 29, 2025
@elizabethengelman elizabethengelman deleted the fix/meta-duplicates-updated branch September 29, 2025 21:11
@BrewTestBot BrewTestBot mentioned this pull request Oct 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leighmcculloch leighmcculloch leighmcculloch approved these changes

Assignees

@elizabethengelman elizabethengelman

Labels

None yet

Projects

DevX
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

stellar contract build --meta results in one new section per entry

3 participants

@elizabethengelman @leighmcculloch