Fetch snapshot values dynamically rather than hardcoding them. #2219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The values should be retrievable out of the archive itself, instead of from an rpc. So that we don't need two data sources and so that this command continues to function for ledgers older than 7 days. |
Member
leighmcculloch
left a comment
There was a problem hiding this comment.
Couple issues that need addressing.
7524a25 to
6f3e622
Compare
fnando
commented
Sep 24, 2025
leighmcculloch
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#2198
Why
So we have a better snapshot representation.
Known limitations
N/A