Skip to content

Conversation

@leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Sep 12, 2025

What

Update soroban sdk version from dependency 22.0.0 to a dependency 23.0.2 in contract templates generated with stellar contract init.

Why

Align contract templates with latest sdk version to ensure compatibility and access to newest features and fixes.

@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Sep 12, 2025
@leighmcculloch leighmcculloch marked this pull request as ready for review September 12, 2025 05:59
Copy link
Member

@fnando fnando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing this to not use the workspace version? This could lead to more than one contract having different versions, no?

@leighmcculloch
Copy link
Member Author

This could lead to more than one contract having different versions, no?

Which is okay. Contracts don't necessarily all get updated on mainnet at the same time. Having it in the workspace encourages lock step development across what are independent deployables.

@leighmcculloch
Copy link
Member Author

This change doesn't prevent folks from using workspace dependencies, it just doesn't set folks up from day one to use workspace dependencies unnecessarily.

@fnando
Copy link
Member

fnando commented Sep 25, 2025

it just doesn't set folks up from day one to use workspace dependencies unnecessarily.

but I thought we wanted that, when we moved to workspaces. 🤔

@leighmcculloch
Copy link
Member Author

Updated to just the version.

@leighmcculloch leighmcculloch enabled auto-merge (squash) September 25, 2025 21:36
@leighmcculloch leighmcculloch merged commit 65c2ba9 into main Sep 25, 2025
31 checks passed
@leighmcculloch leighmcculloch deleted the update-soroban-sdk-version-in-init branch September 25, 2025 21:57
@github-project-automation github-project-automation bot moved this from Backlog (Not Ready) to Done in DevX Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants