Add ledger seq number to stellar tx fetch output
#2193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A small change to include the ledger sequence number, and the ledger status of the fetched tx.
This is only included when the output if
json-formatted, or on the fee table.Dependent on: stellar/rs-stellar-rpc-client#48
Why
While I was looking into fetching events, I realized that the ledger information is not included on the tx and thought that this would be helpful information.
We could alternatively embed this in the json with a custom type, but I wanted to make sure that the returned json could be decoded into an easy-to-access type (xdr::TransactionEnvelope, xdr::TransactionResult or xdr::TransactionMeta) so that scripts could use this if needed.
Known limitations
Cargo deny failure should be fixed when the associated rpc client PR is merged, and released.