-
Notifications
You must be signed in to change notification settings - Fork 123
Fix debug info printed for key names in funding messages #2063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: sagpatil <1414227+sagpatil@users.noreply.github.com>
|
@copilot why are tests failing |
The tests were failing due to missing system dependencies ( Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot revert the changes in address.rs |
Co-authored-by: sagpatil <1414227+sagpatil@users.noreply.github.com>
The
stellar keys generateandstellar keys fundcommands were printing debug representations of key names instead of their clean display format.Before:
After:
Changes Made
Fixed
generate.rs: Changed"Account {:?} funded on {:?}"to"Account {} funded on {:?}"to use theDisplayimplementation instead ofDebugforKeyNameFixed
fund.rs: Changed"Account {:?} funded on {:?}"to"Account {} funded on {:?}"forUnresolvedMuxedAccountAdded
Displayimplementation: Added a properDisplayimplementation forUnresolvedMuxedAccountenum to handle different account types:AliasOrSecret(String)→ displays the alias/secret stringResolved(MuxedAccount)→ displays the muxed accountLedger(u32)→ displays "ledger" or "ledger:N" for non-zero HD pathsThe
KeyNamestruct already had a properDisplayimplementation that shows just the name string, so this change ensures consistent, clean output across both commands.Fixes #1960.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.