Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jul 8, 2025

The stellar keys generate and stellar keys fund commands were printing debug representations of key names instead of their clean display format.

Before:

✅ Account KeyName("issuer") funded on "Test SDF Network ; September 2015"

After:

✅ Account issuer funded on "Test SDF Network ; September 2015"

Changes Made

  1. Fixed generate.rs: Changed "Account {:?} funded on {:?}" to "Account {} funded on {:?}" to use the Display implementation instead of Debug for KeyName

  2. Fixed fund.rs: Changed "Account {:?} funded on {:?}" to "Account {} funded on {:?}" for UnresolvedMuxedAccount

  3. Added Display implementation: Added a proper Display implementation for UnresolvedMuxedAccount enum to handle different account types:

    • AliasOrSecret(String) → displays the alias/secret string
    • Resolved(MuxedAccount) → displays the muxed account
    • Ledger(u32) → displays "ledger" or "ledger:N" for non-zero HD paths

The KeyName struct already had a proper Display implementation that shows just the name string, so this change ensures consistent, clean output across both commands.

Fixes #1960.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: sagpatil <1414227+sagpatil@users.noreply.github.com>
Copilot AI changed the title [WIP] Debug info printed for key name Fix debug info printed for key names in funding messages Jul 8, 2025
Copilot AI requested a review from sagpatil July 8, 2025 19:04
@sagpatil sagpatil self-requested a review July 8, 2025 19:28
@janewang janewang marked this pull request as ready for review July 9, 2025 17:43
@sagpatil
Copy link
Contributor

sagpatil commented Jul 9, 2025

@copilot why are tests failing

Copy link
Contributor Author

Copilot AI commented Jul 10, 2025

@copilot why are tests failing

The tests were failing due to missing system dependencies (libdbus-1-dev and libudev-dev) and missing WASM test artifacts. I fixed these by installing the required system packages and building the test WASM files with make build-test-wasms. All tests now pass successfully. The code changes to fix the debug output formatting don't affect test functionality - they only change the display format from KeyName("issuer") to issuer in the funding messages.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@sagpatil
Copy link
Contributor

@copilot revert the changes in address.rs

Co-authored-by: sagpatil <1414227+sagpatil@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jul 10, 2025

@copilot revert the changes in address.rs

Done! I've reverted the changes in address.rs by removing the Display implementation for UnresolvedMuxedAccount that was added in commit fc9bae9. The file is now back to its original state.

@sagpatil sagpatil enabled auto-merge (squash) July 10, 2025 04:53
@fnando fnando mentioned this pull request Jul 18, 2025
@fnando fnando closed this Jul 19, 2025
auto-merge was automatically disabled July 19, 2025 05:20

Pull request was closed

@github-project-automation github-project-automation bot moved this from Backlog (Not Ready) to Done in DevX Jul 19, 2025
@fnando fnando deleted the copilot/fix-1960 branch July 19, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Debug info printed for key name

4 participants