fix: preserve issue navigator reference results

steipete · steipete · commit 030a49f0ec99 · 2026-06-03T15:23:47.000-07:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## 0.7.1 - Unreleased
 
+- Keep Issue Navigator reference clicks from being overwritten by clipboard seeding, and show unresolved GitHub metadata as the reference label instead of "preview unavailable."
+
 ## 0.7.0 - 2026-05-31
 
 - Add copyable update diagnostics in About so Sparkle install-location failures include bundle path, resolved path, signing, Homebrew, translocation, and quarantine signals. (#70)
diff --git a/Sources/RepoBar/Views/IssueNavigatorModels.swift b/Sources/RepoBar/Views/IssueNavigatorModels.swift
@@ -50,8 +50,14 @@ struct IssueNavigatorScope: Identifiable, Hashable {
 }
 
 extension GitHubReferenceMatch {
+    var issueNavigatorHeaderTitle: String {
+        self.isResolved ? self.title : self.query.displayText
+    }
+
     var issueNavigatorTitle: String {
-        switch self.query {
+        guard self.isResolved else { return self.query.displayText }
+
+        return switch self.query {
         case let .issueNumber(number),
              let .repositoryNameIssueNumber(_, number),
              let .repositoryIssueNumber(_, number):
diff --git a/Sources/RepoBar/Views/IssueNavigatorView.swift b/Sources/RepoBar/Views/IssueNavigatorView.swift
@@ -72,7 +72,7 @@ struct IssueNavigatorView: View {
             self.browserStore.onNavigationStateChange = {
                 self.browserNavigationVersion &+= 1
             }
-            self.updateClipboard(seedIfEmpty: true)
+            self.updateClipboard(seedIfEmpty: Self.shouldSeedClipboardOnAppear(hasInitialMatches: self.results.isEmpty == false))
             if self.results.isEmpty {
                 self.scheduleSearch(immediate: true)
             } else {
@@ -315,7 +315,7 @@ struct IssueNavigatorView: View {
             .frame(width: 32, height: 32)
 
             VStack(alignment: .leading, spacing: 2) {
-                Text(match.title)
+                Text(match.issueNavigatorHeaderTitle)
                     .font(.system(size: 16, weight: .semibold))
                     .lineLimit(1)
                 HStack(spacing: 6) {
@@ -371,6 +371,10 @@ struct IssueNavigatorView: View {
         }
     }
 
+    nonisolated static func shouldSeedClipboardOnAppear(hasInitialMatches: Bool) -> Bool {
+        !hasInitialMatches
+    }
+
     @MainActor
     private func performSearch(generation: UUID) async {
         guard self.isCurrentSearch(generation) else { return }
diff --git a/Tests/RepoBarTests/IssueNavigatorViewTests.swift b/Tests/RepoBarTests/IssueNavigatorViewTests.swift
@@ -0,0 +1,37 @@
+import Foundation
+@testable import RepoBar
+@testable import RepoBarCore
+import Testing
+
+struct IssueNavigatorViewTests {
+    @Test
+    func `initial reference matches do not get overwritten by clipboard seed`() {
+        #expect(!IssueNavigatorView.shouldSeedClipboardOnAppear(hasInitialMatches: true))
+        #expect(IssueNavigatorView.shouldSeedClipboardOnAppear(hasInitialMatches: false))
+    }
+
+    @Test
+    func `decorated issue navigator labels remain parseable for manual search`() {
+        let queries = GitHubReferenceTranslator.queries(from: "1. openclaw/gogcli#673 · 1 PR · add --thread-id to G")
+
+        #expect(queries == [.repositoryIssueNumber(repositoryFullName: "openclaw/gogcli", number: 673)])
+    }
+
+    @Test
+    func `unresolved metadata uses reference label in navigator chrome`() throws {
+        let match = try GitHubReferenceMatch(
+            query: .repositoryIssueNumber(repositoryFullName: "openclaw/imsg", number: 135),
+            title: "GitHub preview unavailable",
+            url: #require(URL(string: "https://github.com/openclaw/imsg/issues/135")),
+            repositoryFullName: "openclaw/imsg",
+            kind: .issue,
+            state: nil,
+            createdAt: nil,
+            updatedAt: Date(timeIntervalSince1970: 0),
+            isResolved: false
+        )
+
+        #expect(match.issueNavigatorHeaderTitle == "openclaw/imsg#135")
+        #expect(match.issueNavigatorTitle == "openclaw/imsg#135")
+    }
+}
