fix: add update diagnostics#71
Conversation
|
Codex review: needs maintainer review before merge. Reviewed May 30, 2026, 11:54 AM ET / 15:54 UTC. Summary Reproducibility: not applicable. for the PR diff itself; the branch adds diagnostics for a reported updater failure, and I reviewed the source diff rather than reproducing the Sparkle install-location error in a signed macOS bundle. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the diagnostics helper only if maintainers intentionally want it to resolve the linked report; otherwise change the PR body to a non-closing reference and keep the updater failure tracked separately. Do we have a high-confidence way to reproduce the issue? Not applicable for the PR diff itself; the branch adds diagnostics for a reported updater failure, and I reviewed the source diff rather than reproducing the Sparkle install-location error in a signed macOS bundle. Is this the best way to solve the issue? Unclear: the implementation is a narrow diagnostics path, but using it as the final fix for the linked updater failure requires maintainer judgment. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 6887b3162e2e. Label changesLabel justifications:
Evidence reviewedAcceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
Adds copyable update diagnostics in About so Sparkle install-location failures include the runtime bundle path, resolved bundle path, update availability, Developer ID signing, Homebrew cask, App Translocation, and quarantine signals.
Fixes #70.
Proof