Skip to content

Revert "Using env.runner_temp instead of home directory to write json file" #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gr2m merged 1 commit into from
Jun 1, 2024
Merged

Revert "Using env.runner_temp instead of home directory to write json file" #76

gr2m merged 1 commit into from
Jun 1, 2024

Conversation

@jamacku
Copy link
Contributor

@jamacku jamacku commented Jun 1, 2024

@jamacku
Copy link
Contributor Author

jamacku commented Jun 1, 2024

I think that the original revert doesn't revert the breaking change introduced in:

https://github.com/stefanbuck/github-issue-parser/pull/59/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346

@FlafyDev This might break your setup again. 😢 Sorry about that. But It will unblock all users who access JSON file directly and haven't noticed yet.

@FlafyDev
Copy link

FlafyDev commented Jun 1, 2024

This might break your setup again. 😢 Sorry about that. But It will unblock all users who access JSON file directly and haven't noticed yet.

yeah that's fine lol. that comment was mostly a joke
i'll subscribe to this PR to know when to update my thing

gr2m
gr2m approved these changes Jun 1, 2024
View reviewed changes
Copy link
Collaborator

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry no idea what happened in #75, it's been a long day ...

@gr2m gr2m merged commit f3e3c10 into stefanbuck:main Jun 1, 2024
@jamacku jamacku deleted the revert-59-joshjohanning/runner_temp branch June 1, 2024 06:45
@jamacku
Copy link
Contributor Author

jamacku commented Jun 1, 2024

sorry no idea what happened in #75, it's been a long day ...

No problem :)

I see that the semantic-release action failed :/

[6:12:00 AM] [semantic-release] › ✘  An error occurred while running semantic-release: ExecaError: Command failed with exit code 128: git tag v3.2.1 c9e47737b81057fcdcbf95d412a34aafb0e4ed00

Not sure what happened there. It should create v3.2.2.

release-app-github-issue-parser bot pushed a commit that referenced this pull request Dec 28, 2024
@semantic-release-bot
build(release): 3.2.1 [skip ci]
ad608ca 
## [3.2.1](v3.2.0...v3.2.1) (2024-12-28)

### Bug Fixes

* **deps:** bump @actions/core from 1.10.1 to 1.11.1 ([aff753a](aff753a))
* ensure dist folder matches release ([#83](#83)) ([5561b47](5561b47))
* Revert "test: set `RUNNER_TEMP` instead of `HOME`" ([#75](#75)) ([4c1d1d7](4c1d1d7))

### Reverts

* Revert "feat: using env.runner_temp instead of home directory to write json f…" ([#76](#76)) ([f3e3c10](f3e3c10))
@release-app-github-issue-parser
Copy link

release-app-github-issue-parser bot commented Dec 28, 2024

🎉 This PR is included in version 3.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gr2m gr2m gr2m approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamacku @FlafyDev @gr2m