fix(checkboxes): correctly parse checkboxes when the template is wrong or missing #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g or missing
When the wrong template is provided, then the action will traceback with the error:
```js
/home/runner/work/_actions/stefanbuck/github-issue-parser/v3/dist/index.js:105
result[key] = content.concat(value);
^
TypeError: Cannot read properties of undefined (reading 'concat')
at /home/runner/work/_actions/stefanbuck/github-issue-parser/v3/dist/index.js:105:33
at Array.forEach (<anonymous>)
at toObject (/home/runner/work/_actions/stefanbuck/github-issue-parser/v3/dist/index.js:97:11)
at run (/home/runner/work/_actions/stefanbuck/github-issue-parser/v3/dist/index.js:161:12)
at 2932 (/home/runner/work/_actions/stefanbuck/github-issue-parser/v3/dist/index.js:184:3)
at __nccwpck_require__ (/home/runner/work/_actions/stefanbuck/github-issue-parser/v3/dist/index.js:7097:43)
at /home/runner/work/_actions/stefanbuck/github-issue-parser/v3/dist/index.js:7117:37
at Object.<anonymous> (/home/runner/work/_actions/stefanbuck/github-issue-parser/v3/dist/index.js:7120:12)
at Module._compile (node:internal/modules/cjs/loader:1241:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
```
Also, checkboxes aren't represented as an array when the issue-form template is not provided.
This commit fixes both issues by correctly parsing checkboxes even when the template is wrong or missing.
Contributor
Author
|
@joshjohanning, @gr2m, Could you please have a look? Thank you. |
gr2m
approved these changes
Apr 29, 2024
Collaborator
gr2m
left a comment
There was a problem hiding this comment.
Looks good to me 👍🏼 great PR
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Contributor
Author
|
Thank you @gr2m 👍 |
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the wrong template is provided, then the action will traceback with the error:
Also, checkboxes aren't represented as an array when the issue-form template is not provided.
This commit fixes both issues by correctly parsing checkboxes even when the template is wrong or missing.
Follow-up to:
Related to:
/cc @stefanbuck