Skip to content

feat: add array/float16 #7435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
udaykakade25 wants to merge 27 commits into
base: develop
Choose a base branch
from
Open

feat: add array/float16 #7435

udaykakade25 wants to merge 27 commits into from
+21,297 −0

Conversation

@udaykakade25
Copy link
Contributor

@udaykakade25 udaykakade25 commented Jun 21, 2025

progresses #7347 and #7273

Description

What is the purpose of this pull request?

This pull request:

  • Adds array/float16 folder

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

This is the third PR. First two PRs are interconnected to each other. In order to merge this PR, we need to first merge PR 1: #7273 and #7347

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 21, 2025
@udaykakade25
Copy link
Contributor Author

udaykakade25 commented Jun 21, 2025

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 21, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 21, 2025
@udaykakade25
Copy link
Contributor Author

udaykakade25 commented Jun 21, 2025

Hello @Planeshifter and @kgryte sir,
With this PR, i have completed array/float16.
Please do review and merge PR along with two previously mentioned PRs.

So, i can start working on adding float16 datatype support for array/base, array/*, strided/8 and ndarray/*

kgryte
kgryte reviewed Jun 21, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 21, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 21, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 21, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 21, 2025
View reviewed changes
kgryte
kgryte requested changes Jun 21, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@udaykakade25 Thank you for working on this. I left a few initial comments. The TL;DR is that the entire implementation needs to be reworked to be implemented in ES5. I strongly encourage you to emulate the style and approach used in array/bool and other custom array types implemented in stdlib.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jun 21, 2025
@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Jun 22, 2025
@udaykakade25
Refactored Polyfill.js
8611f89 
Signed-off-by: Uday Kakade <141299403+udaykakade25@users.noreply.github.com>
@udaykakade25
Copy link
Contributor Author

udaykakade25 commented Jun 29, 2025

@udaykakade25 Thank you for working on this. I left a few initial comments. The TL;DR is that the entire implementation needs to be reworked to be implemented in ES5. I strongly encourage you to emulate the style and approach used in array/bool and other custom array types implemented in stdlib.

Hello @kgryte sir, I have refactored the whole polyfill.js file that follows stdlib style. Thanks for reviewing!!

kgryte
kgryte reviewed Jun 29, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 29, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 29, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 29, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 29, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 29, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 29, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 29, 2025
View reviewed changes
@kgryte
Copy link
Member

kgryte commented Jun 29, 2025

Also, for this PR to move forward, CI should be passing. Currently, CI is failing on linting, benchmarks, examples, and tests.

@udaykakade25
Refactored polyfill.js
12e4814 
Signed-off-by: Uday Kakade <141299403+udaykakade25@users.noreply.github.com>
@udaykakade25
Copy link
Contributor Author

udaykakade25 commented Jun 29, 2025

Also, for this PR to move forward, CI should be passing. Currently, CI is failing on linting, benchmarks, examples, and tests.

Hello @kgryte sir,
I have changes that follow the standards below
TABS Indentation ✅
Alphabetical Order ✅
Offset >>> 0 fix ✅
Readonly added ✅
Error formatting ✅
Utilities Added ✅
No Anonymous functions ✅
Missing Statistics Added ✅

Regarding failed CI checks:
Just Linting errors in Readme.md and Repl.txt are remaining to fix.
Rest other issues are encountered because the assert\has-float16array-support #7347 and assert/is-float16array #7273 PRs is still pending.

@udaykakade25
Update package.json
1f18925 
Signed-off-by: Uday Kakade <141299403+udaykakade25@users.noreply.github.com>
@gururaj1512
docs: add readme
2177682 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gururaj1512
docs: update README and examples
8e7101a 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gururaj1512 gururaj1512 mentioned this pull request Dec 18, 2025
Open
7 tasks
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Dec 19, 2025
@kgryte kgryte self-requested a review December 19, 2025 04:17
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 19, 2025
@kgryte
Copy link
Member

kgryte commented Dec 19, 2025

I see that doctesting is failing due to missing Float16Array support. Will take a look.

@gururaj1512
chore: add and refactor benchmarks
5e33e5c 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gururaj1512
Copy link
Member

gururaj1512 commented Dec 19, 2025 •
edited
Loading

I see that doctesting is failing due to missing Float16Array support. Will take a look.

Should I look into that?
Also if Float16Array doctesting support added lot of cleanup can be carried out by removing .get() from examples.

@gururaj1512
Copy link
Member

gururaj1512 commented Dec 19, 2025

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 19, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 19, 2025
@kgryte
Copy link
Member

kgryte commented Dec 20, 2025

@gururaj1512 Chicken and the egg problem here. Looked into doctest support. Essentially we first need to merge this PR, and then we can add doctest support. And once doctest support is added, we can circle back and clean up the examples.

@gururaj1512
Copy link
Member

gururaj1512 commented Dec 20, 2025

@kgryte, That makes sense. This PR still need some cleanup. I'll mark it up for review once cleaned-up

@kgryte
Copy link
Member

kgryte commented Dec 20, 2025

@gururaj1512 I've made some changes locally. Would you like me to go ahead and push those up before continuing further?

@gururaj1512
Copy link
Member

gururaj1512 commented Dec 20, 2025 •
edited
Loading

@kgryte, I'm fine with it. You can push your changes.

@kgryte
chore: clean-up
3d56a8f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@kgryte
Copy link
Member

kgryte commented Dec 20, 2025

@gururaj1512 Done.

@gururaj1512
refactor: use format for benchmark names
f5df2eb 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
gururaj1512
gururaj1512 reviewed Dec 21, 2025
View reviewed changes
@gururaj1512
fix: handle Float16Array input in Float16Array constructor
4f951f7 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gururaj1512
fix: improve buffer initialization in Float16Array constructor
b3a827f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@gururaj1512
refactor: fix docs and types
4236133
@gururaj1512
fix: clarify return type
f2bd8ba 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
kgryte
kgryte reviewed Dec 23, 2025
View reviewed changes
kgryte
kgryte reviewed Dec 24, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte requested changes

@gururaj1512 gururaj1512 gururaj1512 left review comments

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@udaykakade25 @kgryte @gururaj1512 @stdlib-bot