Add Redis Object Cache exception reporting integration#237
Merged
Conversation
f9bb443 to
5833020
Compare
5833020 to
faed719
Compare
Contributor
Author
Seems to look good now |
LordSimal
commented
Mar 19, 2026
Contributor
Author
|
The callstack up till the constructor is as follows: don't know what we can use at this point to properly detect, that this plugin is present and active |
faed719 to
422ef2d
Compare
|
Nice, I'm gonna see if we can add this easily to Object Cache Pro as well. |
Contributor
Author
|
@stayallive any objections? |
Contributor
Author
|
ping @stayallive |
stayallive
approved these changes
May 20, 2026
stayallive
left a comment
Owner
There was a problem hiding this comment.
Sorry for the delay, this looks good!
Contributor
Author
|
May I request a new release for this new feature please 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: rhubarbgroup/redis-cache#605
This adds custom exception integration for the Redis Object cache Plugin
The action being used is defined in https://github.com/rhubarbgroup/redis-cache/blob/a456c15c9a09269e0418759f644e88b9dc8f9dc0/includes/object-cache.php#L2927
Without this the exception being thrown by the Redis Client (or anything related in that plugin) don't get reported to sentry as it does a
wp_die()and does not re-throw them so the Worpdress error handler can process it.For now there is only the thrown exception as a context in there, but maybe this can be improved in a future version of that plugin to give a bit more context.
Warning
I have NOT yet tested this change. But will try to do that in the upcoming days.