Disable concurrent requests in legacy sync manager#7491
Merged
Conversation
Contributor
|
To what extent does it slow sync? That's one potential reason to avoid doing it. |
Contributor
Author
|
On that system (Raspberry Pi), it shows around 2.5 slots per second before and after, so it doesn't really slow it there. It obviously depends on the network situation and hardware, I'm not sure. With the fix, no restarts have been needed for days, so I'm confident that this workaround resolves the linked issue with sync getting stuck. One thing that's a bit worrisome is that this has nothing to do with the issue originally being reported based on a Genesis sync, there is nothing magical about "1 day", it might happen earlier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets rid of the race that led to #7394 by disabling some of the optimizations introduced in #6722. Given that sync manager will be replaced soon for Fulu, and the long time typically needed until the issue is triggered, not sure how important / appropriate.