address Unify client starting process for rlp#3909
Merged
tersec merged 13 commits intostatus-im:masterfrom Jan 16, 2026
Merged
Conversation
pick e98da11 add era client booting
Contributor
|
Needs cleanup and complexity reduction |
Contributor
Author
|
hey cleaned up a bit by removing the stuff in nim_import and also discarding the import arm as executionclientconf how has all the options that import used to have by itself will need a bit of input about the finalization part and how to reduce the complexity there @advaita-saha |
Contributor
|
Could you please update the running output after the latest changes ? |
Contributor
Author
and the ci test have apparently passed too |
Contributor
|
Ig I need to look into how to handle the era import in this case, we would like the computeKey cache to build after importing. @RazorClient I think the best thing for you would be to leave the era part for now, and make this PR for rlp only For the rlp test vectors, you can run hive consume-rlp or you can maybe use few rlp blocks from test folder |
advaita-saha
requested changes
Jan 15, 2026
advaita-saha
requested changes
Jan 16, 2026
advaita-saha
approved these changes
Jan 16, 2026
kdeme
reviewed
Jan 16, 2026
| bootstrapBlocksFile* {. | ||
| desc: "Import RLP encoded block files before starting the client" | ||
| defaultValue: @[] | ||
| name: "bootstrap-blocks-file" .}: seq[InputFile] |
Contributor
There was a problem hiding this comment.
It is my understanding that this is a way of importing mostly used for testing? And thus really just a dev option?
I mean, the UX of these files is not really there compared to era (where to find them, command line repeat, upfront validation not existing?, etc). Hence, to not clutter cli UX here, would it not be better to be a debug/hidden flag?
Contributor
Author
There was a problem hiding this comment.
yeah does make sense
making it hidden like the rockdb params would be the best idea then imo
bhartnett
reviewed
Jan 16, 2026
| case config.cmd | ||
| of NimbusCmd.`import`: | ||
| importBlocks(config, com) | ||
| of NimbusCmd.`import - rlp`: |
Contributor
There was a problem hiding this comment.
Removing this will have broken the hive tests. See here: https://github.com/ethereum/hive/blob/0976a64d8d4e522a4eb5a8c30d0b0b9c8e8fd41d/clients/nimbus-el/nimbus.sh#L91.
So hive needs to be updated as well.
Contributor
Author
There was a problem hiding this comment.
The general idea was to transition the hive tests to the single binary's commands as per #3793; however, as pointed out, the test will break
so question is, revert this or update Hive?
cc: @advaita-saha
Contributor
There was a problem hiding this comment.
Removing this will have broken the hive tests. See here: https://github.com/ethereum/hive/blob/0976a64d8d4e522a4eb5a8c30d0b0b9c8e8fd41d/clients/nimbus-el/nimbus.sh#L91.
So hive needs to be updated as well.
Aware, hive sync tests are already broken
Will make a PR to harmonise everything along with transition to single binary
Contributor
There was a problem hiding this comment.
FYI, for BALs we use the eels/consume-rlp hive tests which use this rlp import command as well. And these have been working fine up to this point.
Contributor
There was a problem hiding this comment.
Yes
ethereum/sync tests fails
I made a very bandaid like fix for that
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #3899
--bootstrap-blocks-file:<path> — RLP-encoded block files to import before startup.--debug-bootstrap-finalized:<bool> ( default false) — if true, treat those bootstrap treated segments as finalized when importing.