Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reasons for removing windeps.zip downloading are primarily twofold:
There's no point (at least initially for sure, but probably ever) in supporting x86 macOS. It's rapidly fading. If nothing else, the defaults should be switched to ARM macOS, and if x86 really needs to be re-added, that can be looked at later. But right now the CI should be focusing on testing ARM.
--persist-batch-sizelooks very much like a debugging option we probably won't want to ship/document as an end-user supported command-line flag, so signal that appropriately. As with x86 macOS, this can be reviewed later, but as we approach an initial alpha release, it's better to err on the side of not having command-line options which are/were largely debugging artifacts enshrined in the supported set.