This repository was archived by the owner on May 8, 2025. It is now read-only.
Update Pre-commit hooks and enforce git fetch to be successful#274
Merged
staticdev merged 2 commits intostaticdev:mainfrom Mar 30, 2025
Merged
Update Pre-commit hooks and enforce git fetch to be successful#274staticdev merged 2 commits intostaticdev:mainfrom
staticdev merged 2 commits intostaticdev:mainfrom
Conversation
pyenv just has reset tag v2.4.5 to a different commit and now the installation of this role fails on previously existing environments.
staticdev
approved these changes
Mar 30, 2025
Owner
|
Thanks @SirUli, LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I stumbled across the following error while running on our CI:
The reason is that the git module of ansible doesn't enforce the fetch on the one hand. On the other hand, pyenv changed the tag to a different commit and hence caused the trouble initially.
While reviewing the repository i found that pre-commit wasn't updated for a while and did that through
pre-commit autoupdate. This updated a number of hooks in the repository. And these then led to new findings (mainly led by ansible-lint being updated).