Skip to content

Fixed type of .events and .ownEvents properties#4530

Merged
davidkpiano merged 1 commit intonextfrom
fix/type-of-events-property
Nov 30, 2023
Merged

Fixed type of .events and .ownEvents properties#4530
davidkpiano merged 1 commit intonextfrom
fix/type-of-events-property

Conversation

@Andarist
Copy link
Collaborator

@Andarist Andarist commented Nov 30, 2023

No description provided.

@Andarist Andarist requested a review from davidkpiano November 30, 2023 15:03
@changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2023

⚠️ No Changeset found

Latest commit: 6f8dc84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 30, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6f8dc84:

Sandbox Source
XState Example Template Configuration
XState React Template Configuration

Andarist
Andarist commented Nov 30, 2023
View reviewed changes
packages/core/src/StateMachine.ts

public states: StateNode<TContext, TEvent>['states'];
public events: Array<TEvent['type']>;
public events: Array<EventDescriptor<TEvent>>;
Copy link
Collaborator Author

@Andarist Andarist Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which also means that those property names are somewhat misleading. That was also true before since an event is an object - not a string

@davidkpiano davidkpiano merged commit 5dc9777 into next Nov 30, 2023
@davidkpiano davidkpiano deleted the fix/type-of-events-property branch November 30, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidkpiano davidkpiano davidkpiano approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Andarist @davidkpiano