[v5] Add support for partial wildcards (prefix matching) by davidkpiano · Pull Request #1811 · statelyai/xstate

davidkpiano · 2021-01-04T05:29:08Z

This PR adds support for prefix matching with wildcards (and without wildcards for SCXML machines only):

const machine = createMachine({
  // ...
  on: {
    // This transition accepts event types like:
    // "mouse", "mouse.click", "mouse.move.out", etc.
    // but not events like "mouseclick"
    'mouse.*': {/* ... */}
  }
});

https://github.com/davidkpiano/xstate/projects/1#card-52117183

changeset-bot · 2021-01-04T05:29:11Z

🦋 Changeset detected

Latest commit: 5d16a73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
xstate	Major
@xstate/graph	Major
@xstate/immer	Major
@xstate/inspect	Major
@xstate/react	Major
@xstate/test	Major
@xstate/vue	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/core/src/stateUtils.ts

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

packages/core/src/scxml.ts

packages/core/test/interpreter.test.ts

packages/core/src/stateUtils.ts

packages/core/src/scxml.ts

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

packages/core/test/scxml.test.ts

packages/core/src/stateUtils.ts

packages/core/test/eventDescriptors.test.ts

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

packages/core/src/interpreter.ts

packages/core/test/scxml.test.ts

Andarist · 2021-01-05T12:04:16Z

I've reviewed some SCXML tests that got enabled to check if they were enabled correctly - I haven't done that for all of them. I might do it but not sure if you want to stall this PR waiting for that. I might compile a list of enabled tests later for myself to re-check them.

packages/core/src/scxml.ts

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

davidkpiano added 6 commits January 3, 2021 23:16

Add invokeid to doneInvoke(...) event (SCXML instead of plain event)

ed6223b

Recognize send targets starting with '#_<invokeid>'

24a300a

Add wildcard prefix matching

1fc9d0a

Fix broken tests

2e75ace

IDs should be strings

8e66949

Add tests for prefix matching wildcards

bdbcbb2

davidkpiano requested a review from Andarist January 4, 2021 05:29

Andarist reviewed Jan 4, 2021

View reviewed changes

packages/core/src/stateUtils.ts Show resolved Hide resolved

Andarist reviewed Jan 4, 2021

View reviewed changes

packages/core/src/stateUtils.ts Outdated Show resolved Hide resolved

Update packages/core/src/stateUtils.ts

29bbde4

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

davidkpiano commented Jan 4, 2021

View reviewed changes

packages/core/src/scxml.ts Outdated Show resolved Hide resolved

Update packages/core/src/scxml.ts

ae654e9

davidkpiano commented Jan 4, 2021

View reviewed changes

packages/core/src/scxml.ts Outdated Show resolved Hide resolved

davidkpiano commented Jan 4, 2021

View reviewed changes

packages/core/test/interpreter.test.ts Outdated Show resolved Hide resolved

Update packages/core/test/interpreter.test.ts

8304ce6

Andarist reviewed Jan 4, 2021

View reviewed changes

packages/core/src/stateUtils.ts Outdated Show resolved Hide resolved

Andarist reviewed Jan 4, 2021

View reviewed changes

packages/core/src/stateUtils.ts Outdated Show resolved Hide resolved

Andarist reviewed Jan 4, 2021

View reviewed changes

packages/core/src/stateUtils.ts Outdated Show resolved Hide resolved

Andarist reviewed Jan 4, 2021

View reviewed changes

packages/core/src/scxml.ts Show resolved Hide resolved

Update packages/core/src/stateUtils.ts

e3d0ddd

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

Andarist reviewed Jan 4, 2021

View reviewed changes

packages/core/test/scxml.test.ts Show resolved Hide resolved

Andarist reviewed Jan 4, 2021

View reviewed changes

packages/core/src/stateUtils.ts Show resolved Hide resolved

Andarist reviewed Jan 4, 2021

View reviewed changes

packages/core/test/eventDescriptors.test.ts Show resolved Hide resolved

Andarist reviewed Jan 4, 2021

View reviewed changes

packages/core/test/eventDescriptors.test.ts Show resolved Hide resolved

davidkpiano and others added 2 commits January 4, 2021 18:32

Update packages/core/test/eventDescriptors.test.ts

1b9771a

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

Add test for invalid wildcard event descriptors

8d328e9

Andarist reviewed Jan 5, 2021

View reviewed changes

packages/core/src/interpreter.ts Outdated Show resolved Hide resolved

Andarist reviewed Jan 5, 2021

View reviewed changes

packages/core/test/scxml.test.ts Outdated Show resolved Hide resolved

Andarist reviewed Jan 5, 2021

View reviewed changes

packages/core/test/scxml.test.ts Show resolved Hide resolved

Andarist reviewed Jan 5, 2021

View reviewed changes

packages/core/test/scxml.test.ts Outdated Show resolved Hide resolved

Andarist reviewed Jan 5, 2021

View reviewed changes

packages/core/test/scxml.test.ts Outdated Show resolved Hide resolved

Andarist reviewed Jan 5, 2021

View reviewed changes

packages/core/test/scxml.test.ts Outdated Show resolved Hide resolved

Andarist reviewed Jan 5, 2021

View reviewed changes

packages/core/src/scxml.ts Outdated Show resolved Hide resolved

davidkpiano and others added 8 commits January 5, 2021 08:56

Update packages/core/test/scxml.test.ts

b2b1154

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

Update packages/core/test/scxml.test.ts

8496ac9

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

Update packages/core/test/scxml.test.ts

d628600

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

Update packages/core/test/scxml.test.ts

a322c62

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>

Add warning for misplaced wildcards

8d7092f

Commented out problematic tests

4752569

Move send target resolution to action

9250872

Add changeset

5d16a73

davidkpiano merged commit bfc7c68 into next Jan 6, 2021

davidkpiano deleted the v5/wildcard branch January 6, 2021 00:57

github-actions bot mentioned this pull request Jan 6, 2021

Version Packages (alpha) #902

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[v5] Add support for partial wildcards (prefix matching)#1811

[v5] Add support for partial wildcards (prefix matching)#1811
davidkpiano merged 20 commits intonextfrom
v5/wildcard

davidkpiano commented Jan 4, 2021 •

edited

Loading

Uh oh!

changeset-bot bot commented Jan 4, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Andarist commented Jan 5, 2021

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

davidkpiano commented Jan 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jan 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Andarist commented Jan 5, 2021

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

davidkpiano commented Jan 4, 2021 •

edited

Loading

changeset-bot bot commented Jan 4, 2021 •

edited

Loading