Skip to content

Allow enforcement of trailing slashes on urls and links #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jesseleite merged 22 commits into from
Jul 18, 2025
Merged

Allow enforcement of trailing slashes on urls and links #393

jesseleite merged 22 commits into from
Jul 18, 2025

Conversation

@jesseleite
Copy link
Contributor

@jesseleite jesseleite commented Jun 27, 2025 •
edited
Loading

This PR adds support for enforcing trailing slashes on urls and links in generated SEO meta and in the sitemap. This is useful on server hosts that bias towards trailing slashes (ie. Netlify expects trailing slashes for SEO).

Todo

  • Add opt-in config
    • We're not going to offer a config for this at the SEO Pro level. If you need this for statamic/ssg purposes, you can enable it in ssg's config, or across your whole app via URL::enforceTrailingSlashes() in a provider, etc.
  • Flesh out test coverage
    • Everything seems to be working when testing manually though! 💅
  • Add to DOCUMENTATION.md
    • Explain that if you're wanting trailing slashes for statamic/ssg reasons (ie. Netlify), that you should probably use ssg's dedicated config or enable for your app via URL::enforceTrailingSlashes().

References #387
References statamic/cms#11840
References statamic/ssg#203

jesseleite added 19 commits June 27, 2025 17:30
@jesseleite
Add config to enforce trailing slashes on sitemap.
f465a7c
@jesseleite
Handle sitemap config.
b04c20a
@jesseleite
Fix home_url trailing slash in generated meta.
69cc94d
@jesseleite
Make config a bit more generic.
fa3fa95
@jesseleite
Add trailing slash test coverage for URLs in sitemap.
2b5182f
@jesseleite
Add missing test coverage for next_urland prev_url.
28af88d
@jesseleite
Add test coverage to ensure trailing slashes are output in meta cascade
6593259
@jesseleite
Implement trailing slashes in cascade.
d29a0e8
@jesseleite
Pass failing tests around trailing slash on canonical.
612886d
@jesseleite
Add coverage to ensure trailing slashes go back to how user had them …
dd38f99 
…pre-cascade.
@jesseleite
Pass all tests again.
6eadbc3
@jesseleite
Temporary constraint for CI, since v6 is on master atm.
4ff2db4
@jesseleite
Exact version.
432dd63
@jesseleite
Tighten constraints more.
f407006
@jesseleite
Drop old PHP/Laravel versions from test matrix because Statamic v6 does.
6eee1ec
@jesseleite
Kick test suite.
6fe7235
@jesseleite
More updates to test matrix.
a1b3df7
@jesseleite
This PR in core isn't merged yet.
b9a41ae
@jesseleite
Revert urls.enforce_trailing_slashes config on SEO Pro side, as dis…
56b12ba 
…cussed.

We think most use cases revolve around use cases like Netlify/etc., so it's probable that the user then wants trailing slashes on all URLs, not just in SEO meta/sitemap. The fact that we were turning it on and off, could end up generating inaccurate stache. We can revisit later if this is needed.
@jesseleite jesseleite mentioned this pull request Jul 8, 2025
Merged
@jesseleite jesseleite changed the base branch from master to statamic-v6-support July 18, 2025 16:59
@jesseleite jesseleite marked this pull request as ready for review July 18, 2025 17:00
@jesseleite jesseleite merged commit 229d711 into statamic-v6-support Jul 18, 2025
28 checks passed
@jesseleite jesseleite deleted the enforce-trailing-slashes branch July 18, 2025 17:00
This was referenced Jul 18, 2025
Closed
Closed
@duncanmcclean duncanmcclean mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jesseleite