Skip to content

Refactor JSON encoding for form attributes in JS drivers #5153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jesseleite merged 2 commits into from
Jan 28, 2022
Merged

Refactor JSON encoding for form attributes in JS drivers #5153

jesseleite merged 2 commits into from
Jan 28, 2022

Conversation

@jesseleite
Copy link
Contributor

@jesseleite jesseleite commented Jan 28, 2022 •
edited
Loading

  • Delete jsonEncodeForHtmlAttribute() in favour of ->toJson()->entites() modifiers.

@jesseleite jesseleite mentioned this pull request Jan 28, 2022
Merged
2 tasks
@jesseleite jesseleite requested a review from jasonvarga January 28, 2022 19:25
@jesseleite jesseleite merged commit 49b2f9d into master Jan 28, 2022
@jesseleite jesseleite deleted the js-form-driver-refactor-json-encoding branch January 28, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonvarga jasonvarga Awaiting requested review from jasonvarga

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jesseleite