Add a global tag() helper #2724
Closed
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the code in https://github.com/statamic/cms/blob/master/src/View/Antlers/Engine.php#L133-L152 to return the output of a tag, it might be worth to extract this piece and make it available on the Engine. This allows Blade to do the following: ``` @foreach (tag('collection:news', ['limit' => 1]) as $entry) {{ $entry->get('title') }} @Endforeach ``` I don't know that much of the Engine/Antlers internals, so if there's a better way to do this I'm all for it!
Member
|
Thanks for this. Once again though, same thought as on #2717 - introducing a global function. If that chunk of code can be put somewhere reusable like you're suggesting, the |
Contributor
|
@riasvdv I've got the |
Member
|
This would be useful for any tag, rather than making a directive for each tag. |
3 tasks
Member
|
Gonna hold off on this for now and suggest devs plop it in their own helpers file. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the code in https://github.com/statamic/cms/blob/master/src/View/Antlers/Engine.php#L133-L152 to return the output of a tag, it might be worth to extract this piece and make it available on the Engine.
This allows Blade to do the following:
I don't know that much of the Engine/Antlers internals, so if there's a better way to do this I'm all for it!
It's also missing augmentation, not sure how to handle that