Skip to content

docs(preset): Add Jetpack Preset #5261

Merged
chipbuster merged 667 commits intostarship:masterfrom
Indyandie:jetpack
Sep 1, 2023
Merged

docs(preset): Add Jetpack Preset #5261
chipbuster merged 667 commits intostarship:masterfrom
Indyandie:jetpack

Conversation

@Indyandie
Copy link
Copy Markdown
Contributor

@Indyandie Indyandie commented Jun 19, 2023

Jetpack Preset

Description

This is a pseudo minimalist preset inspired by the geometry and spaceship prompts.

Motivation and Context

Preset

Screenshots

jetpack

How Has This Been Tested?

  • basic usage
  • git
  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly. (I hope so. 😓 )
  • I have updated the tests accordingly.

@Indyandie Indyandie changed the title Jetpack docs(preset): Add Jetpack Preset Jun 19, 2023
Comment thread .gitignore Outdated
Comment thread docs/presets/README.md Outdated
Comment thread docs/presets/jetpack.md Outdated
Comment thread docs/presets/jetpack.md Outdated
Comment thread docs/presets/jetpack.md Outdated
Comment thread docs/presets/jetpack.md
renovate Bot and others added 28 commits July 25, 2023 22:50
…hip#4905)

Remove extra backspace from regex in example

In the example, `[\\w-]` would match a literal backspace `\`, the
character `w` or a dash `-`. By removing the backspace, instead it
matches any "word character" `\w` or a dash `-`.
…arship#4921)

Improve Nushell installation instruction

Consistently use `save -f` rather than `save`; the latter fails if the
file already exists

Signed-off-by: Michel Alexandre Salim <michel@michel-slm.name>
…ll pkg publishing (starship#4723)

Handles starship.install (MSI installer) and starship.portable and makes starship an 
empty meta-package that only depends on starship.install. MSI/installer packages 
seem to be preferred over zip-based installers on chocolatey. Proper virtual packages 
that allow choosing either a portable or install variant aren't implemented in chocolatey yet.
Copy link
Copy Markdown
Member

@mickimnet mickimnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional to the code suggestion, please remove all src/ files from your commit.

Comment thread docs/presets/jetpack.md Outdated
@mickimnet
Copy link
Copy Markdown
Member

There is still src/modules/git_status.rs in the pull request. Maybe that is the reason, why the checks are failing.

@Indyandie
Copy link
Copy Markdown
Contributor Author

testing checks in #5347

@Indyandie
Copy link
Copy Markdown
Contributor Author

@mickimnet looks like the checks are passing now... 😮‍💨

Copy link
Copy Markdown
Member

@mickimnet mickimnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread docs/.vuepress/public/presets/toml/jetpack.toml Outdated
Comment thread docs/.vuepress/public/presets/toml/jetpack.toml Outdated
Comment thread docs/.vuepress/public/presets/toml/jetpack.toml Outdated
@chipbuster
Copy link
Copy Markdown
Contributor

Thank you to @davidkna and @mickimnet for reviews, and to @Indyandie for writing this!

@chipbuster chipbuster merged commit 276865e into starship:master Sep 1, 2023
@Indyandie Indyandie deleted the jetpack branch May 31, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.