refactor: reuse generic SmolStrIds in enum extract_variants#9100
Merged
orizi merged 1 commit intostarkware-libs:mainfrom Dec 15, 2025
Merged
refactor: reuse generic SmolStrIds in enum extract_variants#9100orizi merged 1 commit intostarkware-libs:mainfrom
orizi merged 1 commit intostarkware-libs:mainfrom
Conversation
|
This change is |
orizi
approved these changes
Dec 15, 2025
Collaborator
orizi
left a comment
There was a problem hiding this comment.
@orizi reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MoNyAvA)
a discussion (no related file):
@TomerStarkware for 2nd eye.
TomerStarkware
approved these changes
Dec 15, 2025
Collaborator
TomerStarkware
left a comment
There was a problem hiding this comment.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precompute the list of generic parameter identifiers once in PluginTypeInfo::new for enums and pass it to extract_variants, instead of rebuilding a Vec for each variant. This matches the pattern already used for structs in extract_members, removes redundant allocations and avoids repeated interning work while keeping the behavior of is_dependent_type unchanged.