fix: grammar and articles in function and path expression docs#9090
Merged
orizi merged 3 commits intostarkware-libs:mainfrom Dec 15, 2025
Merged
fix: grammar and articles in function and path expression docs#9090orizi merged 3 commits intostarkware-libs:mainfrom
orizi merged 3 commits intostarkware-libs:mainfrom
Conversation
|
This change is |
orizi
requested changes
Dec 14, 2025
Collaborator
orizi
left a comment
There was a problem hiding this comment.
@orizi reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @anim001k)
docs/reference/src/components/cairo/modules/language_constructs/pages/path-expressions.adoc line 7 at r1 (raw file):
* A local variable. In this case the path is a single identifier. * An xref:constant-items.adoc[constant item].
this is wrong.
orizi
approved these changes
Dec 15, 2025
Collaborator
orizi
left a comment
There was a problem hiding this comment.
@orizi reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @anim001k)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An xref:constant-items...inpath-expressions.adoc.See an example of calling it belowinfunctions.adoc.