Conversation
3d88374 to
f95473c
Compare
meship-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion
corelib/src/starknet/info.cairo line 271 at r1 (raw file):
use starknet::contract_address::ContractAddress; use super::BlockInfo; pub use super::v2::ResourceBounds;
I am not sure this is the right approach. I wouldn't like to create a new ResourceBounds, as it is the same for the v2 and v3 modules. However, I am unsure about creating a dependency between those modules.
Code quote:
pub use super::v2::ResourceBounds;
orizi
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @meship-starkware)
corelib/src/starknet/info.cairo line 271 at r1 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
I am not sure this is the right approach. I wouldn't like to create a new ResourceBounds, as it is the same for the v2 and v3 modules. However, I am unsure about creating a dependency between those modules.
No that's good.
corelib/src/starknet/info.cairo line 267 at r1 (raw file):
/// The extended version of the `get_execution_info` syscall result, /// used for client side proving transactions.
The client proving doc isn't relevant here.
f95473c to
73a6790
Compare
meship-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @orizi)
corelib/src/starknet/info.cairo line 267 at r1 (raw file):
Previously, orizi wrote…
The client proving doc isn't relevant here.
Done.
orizi
left a comment
There was a problem hiding this comment.
@orizi reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)
No description provided.