Skip to content

chore(corelib): add a V3 TxInfo struct.#8931

Merged
orizi merged 1 commit intomainfrom
meship/add_a_version3_tx_info_struct
Dec 7, 2025
Merged

chore(corelib): add a V3 TxInfo struct.#8931
orizi merged 1 commit intomainfrom
meship/add_a_version3_tx_info_struct

Conversation

@meship-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@meship-starkware meship-starkware force-pushed the meship/add_a_version3_tx_info_struct branch from 3d88374 to f95473c Compare December 7, 2025 07:38
Copy link
Contributor Author

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


corelib/src/starknet/info.cairo line 271 at r1 (raw file):

    use starknet::contract_address::ContractAddress;
    use super::BlockInfo;
    pub use super::v2::ResourceBounds;

I am not sure this is the right approach. I wouldn't like to create a new ResourceBounds, as it is the same for the v2 and v3 modules. However, I am unsure about creating a dependency between those modules.

Code quote:

pub use super::v2::ResourceBounds;

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @meship-starkware)


corelib/src/starknet/info.cairo line 271 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

I am not sure this is the right approach. I wouldn't like to create a new ResourceBounds, as it is the same for the v2 and v3 modules. However, I am unsure about creating a dependency between those modules.

No that's good.


corelib/src/starknet/info.cairo line 267 at r1 (raw file):

/// The extended version of the `get_execution_info` syscall result,
/// used for client side proving transactions.

The client proving doc isn't relevant here.

@meship-starkware meship-starkware force-pushed the meship/add_a_version3_tx_info_struct branch from f95473c to 73a6790 Compare December 7, 2025 11:18
Copy link
Contributor Author

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @orizi)


corelib/src/starknet/info.cairo line 267 at r1 (raw file):

Previously, orizi wrote…

The client proving doc isn't relevant here.

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

@orizi orizi added this pull request to the merge queue Dec 7, 2025
Merged via the queue into main with commit bf6498a Dec 7, 2025
54 checks passed
@meship-starkware meship-starkware deleted the meship/add_a_version3_tx_info_struct branch December 7, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants