data-bind creates single signal for file inputs#1041
Closed
gazpachoking wants to merge 2 commits intostarfederation:developfrom
Closed
data-bind creates single signal for file inputs#1041gazpachoking wants to merge 2 commits intostarfederation:developfrom
gazpachoking wants to merge 2 commits intostarfederation:developfrom
Conversation
jmstevers
reviewed
Aug 18, 2025
Co-authored-by: Johnathan Stevers <jmstevers@gmail.com>
Contributor
Author
|
This also opens up the possibility to include other fields from |
Collaborator
|
Thanks for the PR! We’ll look into getting this added for the next release. |
Collaborator
|
We added an implementation based on yours for the next release, thanks again! 
|
Collaborator
|
Released in v1.0.0-RC.6, thanks @gazpachoking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal
data-bind should create a single signal for 'file' type inputs with a list of objects describing the files.
This would better match how the data-bind plugin works for all other input types. Every other input type only creates one signal, the exact one the user has specified to bind to. Currently file inputs result in two extra signals that the user has not explicitly specified.
This would also better match the underlying
FileListapi that the input element provides (Which is a list ofFileobjects.) I have named the mime fieldtypeto match the File interfacePR with implementation is here, but no need to use it, just wanted to put this proposal up formally somewhere.