Skip to content

Updated stansummary to not quit on non-fatal error (#971) #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bbbales2 merged 3 commits into from
Jan 23, 2021
Merged

Updated stansummary to not quit on non-fatal error (#971) #972

bbbales2 merged 3 commits into from
Jan 23, 2021

Conversation

@bbbales2
Copy link
Member

@bbbales2 bbbales2 commented Jan 23, 2021

Submisison Checklist

  • Run tests: ./runCmdStanTests.py src/test
  • Declare copyright holder and open-source license: see below

Summary:

Fix for #971

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

mitzimorris
mitzimorris approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stan-buildbot
Copy link
Contributor

stan-buildbot commented Jan 23, 2021

Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 3.43 3.46 0.99 -0.87% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.93 -7.13% slower
eight_schools/eight_schools.stan 0.11 0.11 1.02 2.13% faster
gp_regr/gp_regr.stan 0.15 0.15 1.0 -0.04% slower
irt_2pl/irt_2pl.stan 5.23 5.22 1.0 0.27% faster
performance.compilation 92.38 90.11 1.03 2.46% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.66 8.67 1.0 -0.06% slower
pkpd/one_comp_mm_elim_abs.stan 28.95 28.33 1.02 2.12% faster
sir/sir.stan 136.9 130.48 1.05 4.69% faster
gp_regr/gen_gp_data.stan 0.04 0.04 0.97 -2.65% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.05 3.12 0.98 -2.51% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.4 0.39 1.03 2.47% faster
arK/arK.stan 1.82 1.82 1.0 -0.46% slower
arma/arma.stan 0.61 0.6 1.02 2.11% faster
garch/garch.stan 0.59 0.6 0.99 -0.52% slower
Mean result: 1.00206573872

Jenkins Console Log
Blue Ocean
Commit hash: 761b108

Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@bbbales2 bbbales2 merged commit 968132c into develop Jan 23, 2021
@bbbales2 bbbales2 mentioned this pull request Feb 3, 2021
Closed
@WardBrian WardBrian deleted the bugfix/stansummary-vi branch September 6, 2023 20:17
This was referenced Sep 24, 2024
Closed
Closed
@mitzimorris mitzimorris mentioned this pull request Oct 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitzimorris mitzimorris mitzimorris approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bbbales2 @stan-buildbot @mitzimorris