-
-
Notifications
You must be signed in to change notification settings - Fork 98
Fix/diagnose num chains #1321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/diagnose num chains #1321
Conversation
mitzimorris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch - thanks!
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Submisison Checklist
./runCmdStanTests.py src/testSummary:
Spotted in stan-dev/math#3171, the
diagnosecommand is using the wrong total for the number of transitions. This is becausemcmc::chainsethas different behavior than the oldmcmc::chainsfor thenum_samples()method, so we need to multiply by the number of chains.Intended Effect:
How to Verify:
Side Effects:
Documentation:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: