Skip to content

More information on system error #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WardBrian merged 6 commits into from
Mar 18, 2025
Merged

More information on system error #1316

WardBrian merged 6 commits into from
Mar 18, 2025
+131 −45

Conversation

@WardBrian
Copy link
Member

@WardBrian WardBrian commented Mar 12, 2025

Submission Checklist

  • Run tests: ./runCmdStanTests.py src/test
  • Declare copyright holder and open-source license: see below

Summary:

Attempts to improve the situation in cases like #1310

Intended Effect:

How to Verify:

I don't know a good way of simulating out-of-disk-space directly. You can test on other situations, like unwritable files or
similar. In those cases, you should see:

$ ls -lha # note there is no `w` bit for test_outputs/
-rwxrwxr-x 1 brian brian 2.6M Mar 12 16:27 bernoulli
-rw-rw-r-- 1 brian brian   50 Jun  6  2024 bernoulli.data.json
dr-xr-xr-x 2 brian brian 4.0K Mar 12 16:25 test_outputs
$ ./bernoulli sample data file=bernoulli.data.json output file=test_outputs/foo.csv
basic_ios::clear: iostream error: Permission denied

The "Permission denied" is new in this PR.

Side Effects:

CmdStan now halts in more erroneous situations, such as the above where the output is not writable; in the current code, it happily runs and just produces no outputs.

Documentation:

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@stan-buildbot
Copy link
Contributor

stan-buildbot commented Mar 12, 2025

Name Old Result New Result Ratio Performance change( 1 - new / old )
arma/arma.stan 0.33 0.31 1.07 6.69% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.01 0.01 0.96 -4.0% slower
gp_regr/gen_gp_data.stan 0.03 0.02 1.11 10.14% faster
gp_regr/gp_regr.stan 0.1 0.09 1.13 11.69% faster
sir/sir.stan 70.67 68.26 1.04 3.41% faster
irt_2pl/irt_2pl.stan 4.27 4.12 1.04 3.46% faster
eight_schools/eight_schools.stan 0.06 0.06 1.0 0.3% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.26 0.24 1.08 7.38% faster
pkpd/one_comp_mm_elim_abs.stan 19.69 19.24 1.02 2.32% faster
garch/garch.stan 0.44 0.41 1.07 6.61% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 2.86 2.69 1.06 5.93% faster
arK/arK.stan 2.03 1.81 1.12 10.84% faster
gp_pois_regr/gp_pois_regr.stan 3.03 2.85 1.06 5.95% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 9.02 8.61 1.05 4.53% faster
performance.compilation 187.07 181.59 1.03 2.93% faster
Mean result: 1.0568182647623963

Jenkins Console Log
Blue Ocean
Commit hash: 0d6bd650ebd331395197dd352b2d23d459fb7626

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

@WardBrian
Tests: remove attempts to write to /dev/null
0c17581 
These were never really doing the right thing anyway!
@stan-buildbot
Copy link
Contributor

stan-buildbot commented Mar 13, 2025

Name Old Result New Result Ratio Performance change( 1 - new / old )
arma/arma.stan 0.37 0.34 1.08 7.37% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.01 0.01 0.91 -9.87% slower
gp_regr/gen_gp_data.stan 0.03 0.03 1.02 1.93% faster
gp_regr/gp_regr.stan 0.1 0.1 1.0 0.07% faster
sir/sir.stan 71.82 72.11 1.0 -0.39% slower
irt_2pl/irt_2pl.stan 4.41 4.4 1.0 0.24% faster
eight_schools/eight_schools.stan 0.06 0.06 0.98 -1.6% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.27 0.27 0.99 -1.39% slower
pkpd/one_comp_mm_elim_abs.stan 20.19 20.35 0.99 -0.77% slower
garch/garch.stan 0.46 0.46 1.01 1.17% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 2.92 2.81 1.04 3.55% faster
arK/arK.stan 1.94 1.87 1.04 3.56% faster
gp_pois_regr/gp_pois_regr.stan 3.06 2.97 1.03 3.01% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 9.11 9.09 1.0 0.26% faster
performance.compilation 190.85 193.94 0.98 -1.62% slower
Mean result: 1.0049839440265165

Jenkins Console Log
Blue Ocean
Commit hash: 0d6bd650ebd331395197dd352b2d23d459fb7626

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

@stan-buildbot
Copy link
Contributor

stan-buildbot commented Mar 13, 2025

Name Old Result New Result Ratio Performance change( 1 - new / old )
arma/arma.stan 0.4 0.4 1.0 0.23% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.01 0.01 0.81 -23.03% slower
gp_regr/gen_gp_data.stan 0.03 0.03 0.95 -4.89% slower
gp_regr/gp_regr.stan 0.1 0.11 0.92 -8.52% slower
sir/sir.stan 79.22 82.61 0.96 -4.27% slower
irt_2pl/irt_2pl.stan 5.61 5.57 1.01 0.76% faster
eight_schools/eight_schools.stan 0.07 0.06 1.11 9.97% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.5 0.28 1.76 43.1% faster
pkpd/one_comp_mm_elim_abs.stan 24.37 21.59 1.13 11.4% faster
garch/garch.stan 0.56 0.62 0.91 -10.0% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.32 3.04 1.09 8.6% faster
arK/arK.stan 2.13 1.99 1.07 6.13% faster
gp_pois_regr/gp_pois_regr.stan 3.12 3.38 0.92 -8.24% slower
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 10.09 10.14 1.0 -0.49% slower
performance.compilation 194.05 213.68 0.91 -10.11% slower
Mean result: 1.0366187979690173

Jenkins Console Log
Blue Ocean
Commit hash: 0d6bd650ebd331395197dd352b2d23d459fb7626

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2846.078
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

@WardBrian WardBrian merged commit 37eeb1d into develop Mar 18, 2025
1 check passed
@WardBrian WardBrian deleted the more-information-on-system_error branch March 18, 2025 18:49
@WardBrian WardBrian mentioned this pull request Mar 18, 2025
Closed
@WardBrian WardBrian mentioned this pull request Mar 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveBronder SteveBronder SteveBronder approved these changes

@mitzimorris mitzimorris Awaiting requested review from mitzimorris

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@WardBrian @stan-buildbot @SteveBronder