Remove ValidatorsRegistrationMode#673
Merged
evgeny-stakewise merged 1 commit intomasterfrom Mar 2, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the validator registration mode logic by removing the ValidatorsRegistrationMode enum and replacing it with direct checks on settings.relayer_endpoint. This simplifies the codebase by eliminating an unnecessary abstraction layer - the presence or absence of a relayer endpoint naturally indicates which mode the system operates in.
Changes:
- Removed
ValidatorsRegistrationModeenum fromtypings.pyand related imports - Removed
validators_registration_modeparameter and field fromsettings.py - Replaced all mode enum checks with direct
settings.relayer_endpointtruthiness checks
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/common/typings.py |
Removed ValidatorsRegistrationMode enum definition |
src/config/settings.py |
Removed validators_registration_mode field and parameter from Settings class |
src/withdrawals/tasks.py |
Replaced mode check with settings.relayer_endpoint check for fetching validator manager signature |
src/validators/tasks.py |
Replaced mode checks with relayer endpoint checks in validator funding and registration logic |
src/common/startup_check.py |
Updated startup checks to use relayer endpoint presence instead of mode enum |
src/commands/start/base.py |
Simplified keystore/relayer initialization logic using relayer endpoint checks |
src/commands/start/relayer.py |
Removed mode enum assignment, relying on relayer endpoint parameter instead |
src/validators/signing/tests/test_common.py |
Renamed test method from test_api to test_relayer and updated its documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cyc60
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.